Use latest version of elastalert#129
Closed
iwilltry42 wants to merge 1 commit intobitsensor:masterfrom
Closed
Conversation
iwilltry42
changed the title
Author
|
Closed, because there are more sophisticated PRs already. |
|
Hello, @iwilltry42, which are these sophisticated PRs you mentioned? Additionally, did your Dockerfile that was changed in this PR work with the new yelp/elastalert version? BR, |
Author
|
@nickthegreek89 maybe not more sophisticated, but with the same result/goal: #117 & #122 which are still open. And yes, I'm using it at the moment with elastalert v0.2.1 so it works with Elasticsarch v7.4.1 for me 👍 |
|
Ok @iwilltry42, thanks a lot for the update! Will probably give a try to your Dockerfile and see how it goes! BR, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Dockerfile to use the latest version of yelp/elastalert.
There were some caveats though regarding the used Python version.
yelp/elastalert is now built using Python 3(.6).
When using
alpine:latest as py-ea, one will get Alpine:3.10, whereapk add python3will be Python 3.7.4, which is not available in Alpine 3.9 whichnode:alpineis based upon.That's why I'm pinning the Python version to exact
python=3.6.8-r2which exists in both.I tested this image on our production cluster and can confirm that it works as expected.